Skip to content

Add alert API routes and corresponding tests #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2025

Conversation

WINBIGFOX
Copy link
Contributor

I saw that there were remnants of the Electron-MessageBox Api. I removed the remnants from the dialog and created a new class “Alert”.

PR: NativePHP/laravel
NativePHP/laravel#523

@simonhamp simonhamp requested a review from a team March 24, 2025 12:22
Copy link
Member

@simonhamp simonhamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems really reasonable to me. Thanks!

Copy link
Contributor

@gwleuverink gwleuverink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@simonhamp simonhamp merged commit aa7f108 into NativePHP:main Mar 25, 2025
56 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants